build(deps-dev): bump ruff from 0.15.22 to 0.16.0 - #1854
Conversation
Bumps [ruff](https://github.com/astral-sh/ruff) from 0.15.22 to 0.16.0. - [Release notes](https://github.com/astral-sh/ruff/releases) - [Changelog](https://github.com/astral-sh/ruff/blob/main/CHANGELOG.md) - [Commits](astral-sh/ruff@0.15.22...0.16.0) --- updated-dependencies: - dependency-name: ruff dependency-version: 0.16.0 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
No functional changes are intended. Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
|
ruff 0.16 enables loads of good rulesets so we get a lot of new complaints. I've started fixing these but have not quite finished yet, a few left to fix. |
lru_cache on instance method means the instance is never GC'd. The alternative approache would have been to make the method a @cached_property instead but that's an API change. Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
Making SignedNote a BaseModel is also possible but there seems to be no benefit. Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
|
/gcbrun |
Should be all done now |
|
A newer version of ruff exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
|
|
||
| note: StrictStr = Field(..., alias="note") | ||
| signatures: list[RekorSignature] = Field(..., alias="signatures") | ||
| note: str |
There was a problem hiding this comment.
Hmm, I'm not sure if this one is 1-1? I think StrictStr adds more validations (like not being empty) on top of str.
There was a problem hiding this comment.
The issue is that the containing class is a dataclass (and not a pydantic BaseModel) so IIUC these don't actually do anything currently.
So the alternative would be to make SignedNote a BaseModel but that would be more of a change than what I do here
|
|
||
| inner = (index ^ (size - 1)).bit_length() | ||
| border = bin(index >> inner).count("1") | ||
| border = (index >> inner).bit_count() |
Bumps ruff from 0.15.22 to 0.16.0.
Release notes
Sourced from ruff's releases.
... (truncated)
Changelog
Sourced from ruff's changelog.
... (truncated)
Commits
a2635fdBump 0.16.0 (#27136)3433449[ty] Reuse full call diagnostics for implicit setter calls (#27115)2240070Reflectruff: ignoreand--add-ignorestabilization in documentation (#27...17ef711Stabilize--add-ignore(#27125)ef912bbAdd newly stabilized rules to defaults (#27055)b30f040Stabilize new default rules (#27035)bcd70c5Exclude Markdown files fromformat-devruns (#27052)87e51e2Fixformat --checkspans for syntax errors (#27045)afe2723[flake8-gettext] Stabilize qualified-name and built-in binding resolution (...a9702d8[flake8-bandit] Stabilize string literal binding resolution (S310) (#26944)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)