Add DogStatsD event support to monitors#62
Merged
Conversation
[AUD-6993] --- These changes introduce an optional event configuration to monitors. The monitor will still send a metric but not also includes the option to send an event with "rich context" as well as the metric. I think another iteration of this could split events out to support event-only configurations. - add optional per-monitor event configuration parsing and defaults - emit one Datadog event per returned SQL row alongside the configured metric - exclude event payload columns from metric tags - validate event alert type and priority during config load/startup - close query rows after each monitor cycle - document event monitor configuration and additive metric behavior
a7fe626 to
0d3c563
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AUD-6993
These changes introduce an optional event configuration to monitors. The monitor will still send a metric but now also includes the option to send an event with "rich context" as well as the metric. I think another iteration of this could split events out to support event-only configurations.