[Midnight] Darkmoon Blood: buff all secondaries tied for lowest#11492
Closed
mat-simon wants to merge 1 commit into
Closed
[Midnight] Darkmoon Blood: buff all secondaries tied for lowest#11492mat-simon wants to merge 1 commit into
mat-simon wants to merge 1 commit into
Conversation
util::lowest_stat() returns only the first stat in priority order, so on a tie a single secondary buff fired. Trigger every secondary whose composite rating equals the minimum instead, expiring the rest.
mat-simon
force-pushed
the
darkmoon-blood-tie
branch
from
7b64a84 to
e1ebca2
Compare
Member
|
Addressed by #11493 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a tie for the lowest secondary, Blood should buff every tied stat, not just the first in priority order (confirmed in-game).