chore(deps): bump pino-http 10→11 + pino 9→10#349
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
pino-http 11 depends on pino ^10, so adopting it requires the matched
pino major bump — otherwise the pino v9 logger instance passed to
pinoHttp({ logger }) in src/logger.ts type-mismatches and node_modules
ends up with split pino majors.
pino 10's only breaking change is dropping Node 18; the runtime is
node:24-alpine, so it's unaffected. No API changes touch LoggerOptions,
stdTimeFunctions, the transport config, or logger() usage. pino-pretty 13
is transport-agnostic and rides along on pino 10.
Verified: typecheck green (root/app/sdk/agent), root suite 563/563,
requestLogger middleware exercised end-to-end in the integration tests.
Rebased onto main after the minor-group + node:24 merges.
rz1989s
force-pushed
the
chore/pino-http-11
branch
from
cf44dde to
4c8ff28
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adopts
pino-http10→11. Dependabot's #330 bumped pino-http alone, but pino-http 11 depends onpino^10 — so the matchedpinomajor bump is required, otherwise the pino v9loggerinstance passed topinoHttp({ logger })insrc/logger.tstype-mismatches andnode_modulessplits pino across two majors. This PR bumps both as the coordinated set.Why pino 10 is safe here
node:22-alpine(build + runtime stages) → unaffected.LoggerOptions,stdTimeFunctions.isoTime, thetransportconfig, orlogger().pino-pretty13 (dev transport) is transport-agnostic (pino-abstract-transport^2) and rides along on pino 10.Verification (off latest
main, fresh worktree)pnpm typecheck— green across root / app / sdk / agent (confirms thepinoHttp({ logger })type alignment on the dedupedpino@10.3.1).pnpm test -- --run(root) — 563/563 passed;requestLoggermiddleware (requestId / customLogLevel / custom messages) exercised end-to-end in the supertest integration tests.Supersedes #330 (closed as superseded on merge).