chore(deps): migrate app to vite 8 + @vitejs/plugin-react 6 (closes #336 path)#353
Merged
Conversation
plugin-react 6 hard-requires vite ^8 (the Rolldown era), so #336 needs the coordinated vite 6->8 bump. plugin-react 6's new peers (@rolldown/plugin-babel, babel-plugin-react-compiler) are both OPTIONAL (peerDependenciesMeta), so no extra deps are needed — just vite + the plugin. The app's vite.config is minimal (react + tailwind + dev proxy) and uses none of vite 8's renamed options (rollupOptions->rolldownOptions, esbuild->oxc), so no config changes are required. @tailwindcss/vite 4.3.1 and vitest 4 already declare vite ^8 support. Note: pinning the app to vite ^8 dedups every workspace's vitest onto vite 8.1.0 (no more vite 7), so the whole suite now transforms under vite 8. Verified off latest main, full suite under vite 8.1.0: typecheck green (root/app/sdk/agent) vite 8 production build — 459 modules, clean root 563 / sdk 118 / app 577 / agent 1718 (+2 skipped) Supersedes #336.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unblocks Dependabot #336 (@vitejs/plugin-react 4→6) by doing the coordinated vite 6→8 migration it requires. plugin-react 6 hard-requires
vite^8 (the Rolldown era).Why this stayed small
@rolldown/plugin-babel+babel-plugin-react-compilerare both optional (peerDependenciesMeta.optional) — only needed for the React Compiler / Rolldown-babel. Not installed.vite.config.tsis minimal (react()+tailwindcss()+ a dev proxy) and uses none of vite 8's renamed options (rollupOptions→rolldownOptions,esbuild→oxc), so no config changes.@tailwindcss/vite4.3.1 (already on main) and vitest 4 both already declarevite^8 support.Note: workspace-wide vite dedup
Pinning the app to
vite^8 dedups every workspace's vitest onto vite 8.1.0 (no more vite 7) — so the whole test suite now transforms under vite 8, not just the app. Verified accordingly below.Verification (fresh worktree off latest
main, all under vite 8.1.0)pnpm typecheck— green (root / app / sdk / agent)vite build— vite v8.1.0, 459 modules transformed, clean (Rolldown bundler)Supersedes #336 (closed as superseded on merge).