Skip to content

feat(certificate): add RFC 9399 logotype parsing to inspect command#1636

Draft
agustinushanssen wants to merge 1 commit into
smallstep:masterfrom
agustinushanssen:add-rfc9399-logotypes
Draft

feat(certificate): add RFC 9399 logotype parsing to inspect command#1636
agustinushanssen wants to merge 1 commit into
smallstep:masterfrom
agustinushanssen:add-rfc9399-logotypes

Conversation

@agustinushanssen
Copy link
Copy Markdown

This parses the logotype extension (OID 1.3.6.1.5.5.7.1.12) and prints the URI to the console output. Includes unit tests for all logotype categories.

Name of feature:

Add RFC 9399 logotype parsing to the step certificate inspect command.

Pain or issue this feature alleviates:

Fixes #1359. Previously, the CLI could not extract or display Logotype Extensions (OID 1.3.6.1.5.5.7.1.12). This adds the required ASN.1 structs to safely unmarshal the data and print the Logotype URI directly to the terminal.

Why is this important to the project (if not answered above):

It allows developers and administrators to inspect certificates (like VMCs) that contain embedded SVGs or external branding links without needing to drop down to a raw OpenSSL ASN.1 parser.

Is there documentation on how to use this feature? If so, where?

No new documentation is required; the output automatically appears in the Extensions section when running step certificate inspect <cert>.

In what environments or workflows is this feature supported?

Tested and working locally via make test and manually tested against a production VMC certificate (LinkedIn).

In what environments or workflows is this feature explicitly NOT supported (if any)?

None

Note for reviewers: This initial PR only inspects and prints the URI. It does not natively download or decompress the image to a file. I wanted to get your architectural feedback first: would you prefer a dedicated --export-logotype flag for that in a future PR, or is printing the URI sufficient for now?

Supporting links/other PRs/issues:

Resolves #1359

💔Thank you!

This parses the logotype extension (OID 1.3.6.1.5.5.7.1.12) and prints the URI to the console output. Includes unit tests for all logotype categories.
@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for inspecting or extracting RFC9399 logotypes

3 participants