doc: fix README logo on dark theme and add dark-mode variant#257
Merged
Conversation
Use the true-transparent logo source (clean letter counters and circle centers) for the full README logo, and add a dark-mode variant of it. The README serves the dark variant through <picture> + prefers-color-scheme so the logo reads well on GitHub's dark theme; the light logo is kept for the light theme and for the Sphinx docs, which stay light-only. - SO3_with_text.png : full logo (light), true-transparent source - SO3_with_text_dark.png : full logo (dark variant, navy -> light blue)
daniel-rossier
force-pushed
the
doc/readme-logo-dark
branch
from
c17bd98 to
a7ce44b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The README logo (
SO3_with_text.png) has its letter counters (the insides of O, B, R…) and circle centers filled with opaque white instead of transparency. This is invisible on a white page, but on GitHub's dark theme it shows up as white blobs, and the navy wordmark/subtitle reads poorly.Fix
SO3_with_text.png: white counters/centers → transparent (identical rendering in light mode).SO3_with_text_dark.png: dark-mode variant (navy wordmark/subtitle recolored to light blue, orange kept).README.md:<picture>+prefers-color-scheme→ dark variant on the dark theme, original on the light theme.Verify by viewing the README on GitHub in dark mode.