Skip to content

chore(ldx-sync-client): update ldx_sync client to 2026-05-07 [IDE-1881]#603

Open
nick-y-snyk wants to merge 1 commit into
mainfrom
chore/IDE-1881_update-ldx-sync-client-to-2026-05-07
Open

chore(ldx-sync-client): update ldx_sync client to 2026-05-07 [IDE-1881]#603
nick-y-snyk wants to merge 1 commit into
mainfrom
chore/IDE-1881_update-ldx-sync-client-to-2026-05-07

Conversation

@nick-y-snyk
Copy link
Copy Markdown
Contributor

@nick-y-snyk nick-y-snyk commented May 8, 2026

Replaces the generated 2024-10-15 ldx_sync client with 2026-05-07.

Changes

  • ldx_sync/2024-10-15/ldx_sync/2026-05-07/ (regenerated from new spec)
  • resolver.go — version string updated, import alias v20241015v20260507
  • mocks/ldx_sync.go — regenerated
  • resolver_test.go — version assertions updated

Why

The 2026-05-07 API drops the enforced field (merged into locked) and adds additionalProperties: false to response schemas. See IDE-1881 and snyk/ldx-sync#110.

Notes

snyk-ls imports this client — it will need a follow-up to update its import path from 2024-10-15 to 2026-05-07.

Replace the 2024-10-15 generated client with the new 2026-05-07 version.

The new API version drops the `enforced` field (merged into `locked`) and
tightens response schemas with additionalProperties: false throughout.
@nick-y-snyk nick-y-snyk requested review from a team as code owners May 8, 2026 12:20
@snyk-io
Copy link
Copy Markdown

snyk-io Bot commented May 8, 2026

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues
Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@snyk-io
Copy link
Copy Markdown

snyk-io Bot commented May 8, 2026

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues
Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@snyk-pr-review-bot
Copy link
Copy Markdown

PR Reviewer Guide 🔍

🧪 PR contains tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Breaking Interface Change 🔴 [critical]

Updating the Organization type alias and the Config field in LdxSyncConfigResult from v20241015 to v20260507 types is a breaking contract change. Any consumer of this package (like snyk-ls) that accesses fields removed in the new version (e.g., Enforced in settings metadata, or specific fields in ConfigData like ProxyConfig) will fail to compile. As this is a public pkg in a library, versioning or a migration shim should be considered if backwards compatibility is required.

	Config      *v20260507.UserConfigResponse
	RemoteUrl   string
	ProjectRoot string
	Error       error
}

// Organization is the struct we return to consumers. We redefine it so that consumers don't need to be aware of the
// LDX-Sync api version.
// For the initial release pf LDX-Sync they are identical so we use an alias.
type Organization v20260507.Organization
📚 Repository Context Analyzed

This review considered 55 relevant code sections from 14 files (average relevance: 0.89)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant