fix: isolate test environment from external variables#613
Open
robertolopezlopez wants to merge 3 commits into
Open
fix: isolate test environment from external variables#613robertolopezlopez wants to merge 3 commits into
robertolopezlopez wants to merge 3 commits into
Conversation
…iables in tests and use it across test suites
…iables in tests and use it across test suites
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
PR Reviewer Guide 🔍
|
danskmt
reviewed
May 26, 2026
Comment on lines
+5
to
+12
| // snykAPIKey is the AutomaticEnv name for configuration.API_URL (viper key "snyk_api"). | ||
| // Keep aligned with pkg/configuration/constants.go. | ||
| const snykAPIKey = "SNYK_API" | ||
|
|
||
| // KnownLeakEnvironmentKeys is cleared when [IsolateEnvironmentForTest] is called with no arguments. | ||
| var KnownLeakEnvironmentKeys = []string{ | ||
| snykAPIKey, | ||
| } |
Contributor
There was a problem hiding this comment.
I guess you can use the value from pkg/configuration/constants.go directly here
danskmt
reviewed
May 26, 2026
Comment on lines
+22
to
+27
| for _, k := range toClear { | ||
| if k == "" { | ||
| continue | ||
| } | ||
| t.Setenv(k, "") | ||
| } |
Contributor
There was a problem hiding this comment.
should consider if is lowercase / uppercase?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds an extendable mechanism to ignore environment variables in unit tests.
Checklist
make test)make generate)make lint)go get github.com/snyk/go-application-framework@YOUR_LATEST_GAF_COMMITin thecliv2directory.go.modto point to your local GAF code.go mod tidyin thecliv2directory.go.modandgo.sumchanges.