Skip to content

[all] Fix float compilation#6115

Merged
fredroy merged 3 commits into
sofa-framework:masterfrom
bakpaul:26_05_fix_float_compilation
May 27, 2026
Merged

[all] Fix float compilation#6115
fredroy merged 3 commits into
sofa-framework:masterfrom
bakpaul:26_05_fix_float_compilation

Conversation

@bakpaul

@bakpaul bakpaul commented May 18, 2026

Copy link
Copy Markdown
Contributor

In the process of testing a CUDA PR I compiled SOFA in float. These where the required changes.
I left out all of the SoftRobotic suite (SoftRobots, SoftRobots.Inverse and MOR) because it touched to critical part such as solvers. I guess that if one day we really want to compile it in float we'll have to take the time to clean them properly.

[ci-depends-on https://github.com/sofa-framework/BeamAdapter/pull/229]
[ci-depends-on https://github.com/sofa-framework/SofaPython3/pull/611]

[with-all-tests]


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@sofabot

sofabot commented May 18, 2026

Copy link
Copy Markdown
Collaborator

[ci-depends-on] detected during build #1.

To unlock the merge button, you must

@bakpaul bakpaul added pr: fix Fix a bug pr: status to review To notify reviewers to review this pull-request labels May 18, 2026
@sofabot

sofabot commented May 19, 2026

Copy link
Copy Markdown
Collaborator

[ci-depends-on] detected during build #2.

To unlock the merge button, you must

@sofabot

sofabot commented May 19, 2026

Copy link
Copy Markdown
Collaborator

[ci-depends-on] detected during build #3.

To unlock the merge button, you must

@bakpaul bakpaul added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels May 21, 2026
@hugtalbot hugtalbot changed the title [All] Fix float compilation [all] Fix float compilation May 21, 2026
@sofabot

sofabot commented May 21, 2026

Copy link
Copy Markdown
Collaborator

[ci-depends-on] detected during build #4.

To unlock the merge button, you must

@fredroy fredroy force-pushed the 26_05_fix_float_compilation branch from dd51fbe to f2cf6f9 Compare May 27, 2026 07:00
@fredroy

fredroy commented May 27, 2026

Copy link
Copy Markdown
Contributor

[ci-build][with-all-tests]

@sofabot

sofabot commented May 27, 2026

Copy link
Copy Markdown
Collaborator

[ci-depends-on] detected during build #5.

All dependencies are merged/closed. Congrats! 👍

@sofabot

sofabot commented May 27, 2026

Copy link
Copy Markdown
Collaborator

[ci-depends-on] detected during build #6.

All dependencies are merged/closed. Congrats! 👍

bakpaul and others added 3 commits May 27, 2026 20:11
…nent/collision/detection/intersection/CCDTightInclusionIntersection.cpp

Co-authored-by: Alex Bilger <alxbilger@users.noreply.github.com>
@fredroy fredroy force-pushed the 26_05_fix_float_compilation branch from f2cf6f9 to 3e1d680 Compare May 27, 2026 11:11
@sofabot

sofabot commented May 27, 2026

Copy link
Copy Markdown
Collaborator

[ci-depends-on] detected during build #7.

All dependencies are merged/closed. Congrats! 👍

@fredroy fredroy merged commit fbb3f75 into sofa-framework:master May 27, 2026
12 of 13 checks passed
@hugtalbot hugtalbot added this to the v26.06 milestone Jun 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants