Skip to content

[FEM] Refactor templates in latest FEM classes#6124

Open
alxbilger wants to merge 5 commits into
sofa-framework:masterfrom
alxbilger:refactoringtemplatefem
Open

[FEM] Refactor templates in latest FEM classes#6124
alxbilger wants to merge 5 commits into
sofa-framework:masterfrom
alxbilger:refactoringtemplatefem

Conversation

@alxbilger

@alxbilger alxbilger commented May 23, 2026

Copy link
Copy Markdown
Contributor

The latest FEM classes defined custom names and custom template names so that the class is registered in the factory with this custom name. However, this is not a good practice. This PR restores the regular pattern where the class is registered using its own class. Because of this, I could also remove the Element prefix on all the FEM classes.

Before:

<PrismFEMMass/>

After:

<FEMMass template="Vec3,Prism"/>

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@alxbilger alxbilger added pr: status to review To notify reviewers to review this pull-request pr: clean Cleaning the code labels May 23, 2026
@alxbilger alxbilger force-pushed the refactoringtemplatefem branch from 83f01b3 to b5016d0 Compare May 28, 2026 07:16
@hugtalbot

Copy link
Copy Markdown
Contributor

Conflicts to be solved @alxbilger
Could you also add a short description please?

@alxbilger alxbilger force-pushed the refactoringtemplatefem branch from c6dd38d to 92e3339 Compare June 11, 2026 09:26
@hugtalbot hugtalbot added this to the v26.06 milestone Jun 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: clean Cleaning the code pr: status to review To notify reviewers to review this pull-request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants