feat: audio tag hls support#1079
Open
closetcaiman wants to merge 20 commits into
Open
Conversation
mdydek
requested changes
Jun 1, 2026
mdydek
reviewed
Jun 3, 2026
Comment on lines
+52
to
+54
| // AudioNode::~AudioNode() -> cleanup() does not call the virtual disable(), | ||
| // so the daemon thread is not guaranteed to have been joined yet. A still | ||
| // joinable std::thread would call std::terminate() on destruction. |
Collaborator
There was a problem hiding this comment.
i don't think this comment gives some important insight, tbh it can be removed
Comment on lines
+74
to
+75
| [[deprecated( | ||
| "StreamerNode is legacy and will be removed. Use AudioFileSourceNode via the <Audio> component instead.")]]; |
Collaborator
There was a problem hiding this comment.
we do not want to expose that probably, I mean our end users won't see it anyway because they touch only js side not underlying cpp
Comment on lines
+30
to
+32
| } else if (!options.memoryData.empty()) { | ||
| openResult = decoder_->openMemory( | ||
| contextSampleRate, options.memoryData.data(), options.memoryData.size()); |
Collaborator
There was a problem hiding this comment.
Suggested change
| } else if (!options.memoryData.empty()) { | |
| openResult = decoder_->openMemory( | |
| contextSampleRate, options.memoryData.data(), options.memoryData.size()); | |
| } else { | |
| openResult = decoder_->openMemory( | |
| contextSampleRate, options.memoryData.data(), options.memoryData.size()); |
existence of one of this option is checked in AudioFileSourceNode, we can probably simplified this branch and maybe add comment about it
| decoder_ = std::make_unique<miniaudio_decoder::MiniAudioDecoder>(); | ||
| } | ||
|
|
||
| decoding::DecoderResult openResult = Ok(None); |
Collaborator
There was a problem hiding this comment.
Suggested change
| decoding::DecoderResult openResult = Ok(None); | |
| decoding::DecoderResult openResult = Err("Some init value"); |
I think initializing it with err value would be semantically more correct
Collaborator
There was a problem hiding this comment.
it should be replaced of course further in the code
Comment on lines
+155
to
+157
| // True when the audio thread itself wrote onPositionChangedFlush (e.g. EOF), | ||
| // so sendOnPositionChangedEvent knows not to sync currentTime_ from the daemon. | ||
| bool audioThreadSetFlush_{false}; |
Collaborator
There was a problem hiding this comment.
I'm wondering if that is needed, can't we think of a way to simplify this logic and then sync times between threads in simpler manner?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #
Introduced changes
HLSsupport in<Audio>SeekDecoderDaemonclass which holdSPSCs for communication between JS thread (seek commands) and Audio thread (decoded frames). The class is used as a daemon thread (viaoperator()()) that is spawned onplayand joined ondisable. Usesdecoding::IncrementalAudioDecoderdepending on the file format.AudioFileSourceNodehandles 3 threads:decoder->seekToTime, drains frameSPSCof stale frames in case of seek, pushes the decoded frames into the frameSPSCSPSC, in case of seek request outputs silenceNodeOptionsParserto handleHLSformat and throw in case of ffmpeg-less build when processing ffmpeg-required formatsStreamerNode@deprecatedannot on the JS sideChecklist