fix(PeriodicWave): use < instead of <= for 24 kHz table size boundary#1081
Closed
spikything wants to merge 1 commit into
Closed
fix(PeriodicWave): use < instead of <= for 24 kHz table size boundary#1081spikything wants to merge 1 commit into
spikything wants to merge 1 commit into
Conversation
On Android devices where PROPERTY_OUTPUT_SAMPLE_RATE is exactly 24000, new AudioContext() sets sampleRate_ to 24000 and getPeriodicWaveSize() returned 2048 (Nyquist 12 kHz), causing OscillatorNode to roll off severely from ~9.5 kHz and be silent at 12 kHz. Change <= to < so that exactly-24000 Hz gets the 4096-entry table. Reading back actual Oboe stream rate after open could be a follow-up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Android devices where
PROPERTY_OUTPUT_SAMPLE_RATEis exactly 24000,new AudioContext()setssampleRate_to 24000 andgetPeriodicWaveSize()returned 2048 (Nyquist 12 kHz), causing OscillatorNode to roll off severely
from ~9.5 kHz and be silent at 12 kHz.
Change
<=to<so that exactly-24000 Hz gets the 4096-entry table.Reading back the actual Oboe stream rate after open is a separate follow-up.
Closes #1080
None.
Introduced changes
PeriodicWave::getPeriodicWaveSize(): change<= 24000to< 24000so devices with a 24 kHz preferred sample rate use the 4096-entry wavetable instead of 2048Checklist