Drop user-facing support for ScipBuildTool#886
Closed
jupblb wants to merge 2 commits into
Closed
Conversation
ScipBuildTool is now an internal worker dispatched only when the Bazel aspect (scip_java.bzl) invokes 'scip-java index --scip-config <file>'. User-facing changes: - Remove 'index-dependency' subcommand. - Hide --scip-config, --scip-ignored-javac-option-prefixes, --scip-ignored-annotation-processors, and --strict-compilation from 'scip-java index --help'. - Drop the 'SCIP Build Tool' help section and fix the misplaced description on --build-command. - Stop auto-detecting lsif-java.json / scip-java.json files; the only supported build tools advertised to users are Maven and Gradle. - Drop jq from the Dockerfile, Nix flake, dev-shell docs, and the scip-java docker wrapper (it only existed to read lsif-java.json). Internal: - BuildTool.autoOrdered no longer lists ScipBuildTool. - IndexCommand.run() early-returns into ScipBuildTool when --scip-config is provided, keeping the Bazel aspect functional. - ScipBuildTool.usedInCurrentDirectory() always returns false and parsedConfig only reads index.scipConfig. Tests/snapshots: - Remove ScipBuildToolSuite, TracingServer, LibrarySnapshotGenerator, AggregateSnapshotGenerator, SemanticdbJavacSnapshotGenerator, LibrarySnapshotSuite, and the org/jetbrains/exposed snapshot fixtures. - SaveSnapshots and SnapshotSuite are simplified to only drive MinimizedSnapshotScipGenerator.
ScipBuildTool is dispatched exclusively from IndexCommand.run() when the Bazel aspect passes --scip-config, so a lot of its surface area was dead code. Net: -501 lines. ScipBuildTool: - No longer extends BuildTool. It does not participate in detection, so the name/isHidden/usedInCurrentDirectory overrides served no purpose. generateScip() is renamed to run(). - Drop the Kotlin compilation path (~150 lines, K2JVMCompiler, message collector, MPP common-source handling). The Bazel aspect only writes *.java files to sourceFiles, so this code was unreachable. - Drop Coursier-based dependency resolution. The aspect passes the full classpath directly, never the 'dependencies' field. - Drop Coursier-based JVM resolution (JvmIndex/JvmCache/JavaHome). The aspect always sets 'javaHome'; the worker now requires it. - Drop the JDK 'kind' branch and module-info partitioning. Bazel never sets 'kind'. - Drop the strictCompilation gate and the in-class ListBuffer that used to combine Java + Kotlin compile attempts. - Slim Config from 13 to 9 fields (drop dependencies, jvm, kind, plus the Dependency case class and custom codec). IndexCommand: - Drop --strict-compilation (only consumed by the removed code path). - Drop --scip-ignored-javac-option-prefixes and --scip-ignored-annotation-processors. These were never propagated by BazelBuildTool to the per-target invocations, so they were dead. Dependencies.scala: - Drop kotlinMPPCommon (sole caller was the removed Kotlin compile path). build.sbt: - Drop the cli project's runtime dependency on kotlin-compiler-embeddable and the four kotlin-scripting-* artifacts; nothing in the cli references them anymore. GradleJavaToolchains.scala: - Drop the @language("Groovy") IDE hint; its provider class was only available transitively via the kotlin-compiler-embeddable artifact we just removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.