Skip to content

reimplement: SHC_3BB0A8C1_0x0047B490 100%#123

Draft
TheRedDaemon wants to merge 1 commit into
mainfrom
reimpl/SHC_3BB0A8C1_0x0047B490
Draft

reimplement: SHC_3BB0A8C1_0x0047B490 100%#123
TheRedDaemon wants to merge 1 commit into
mainfrom
reimpl/SHC_3BB0A8C1_0x0047B490

Conversation

@TheRedDaemon

Copy link
Copy Markdown
Contributor

"fcntl.h" contains the macros for the OpenFlags of Windows, "sys/stat.h" the flags for the pmode.

We should therefore remove the enum and use the windows constants instead.

@TheRedDaemon TheRedDaemon requested a review from gynt June 20, 2026 20:30
@TheRedDaemon TheRedDaemon added the declaration/type change This requires changes to the generated/exported types or definitions. label Jun 20, 2026
@gynt

gynt commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Supported by 54f811c

@gynt gynt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Desired changes have been implemented upstream a1f7e6d

@TheRedDaemon TheRedDaemon force-pushed the reimpl/SHC_3BB0A8C1_0x0047B490 branch from 5b19452 to 4ac3ac6 Compare June 24, 2026 19:59
@TheRedDaemon

Copy link
Copy Markdown
Contributor Author

@gynt Do you want to keep OpenFlag.hpp and its IntVersion?

@gynt

gynt commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

You are right it can go! Will fix.

@gynt

gynt commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

declaration/type change This requires changes to the generated/exported types or definitions.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants