reimplement: SHC_3BB0A8C1_0x0047B590 100%#124
Draft
TheRedDaemon wants to merge 1 commit into
Draft
Conversation
TheRedDaemon
added
the
declaration/type change
gynt
reviewed
Jun 20, 2026
gynt
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Yep, once again full circle:
I suggest to remove the
UnkSoundFlagsAndLoopCountas value type completely and instead try to use bit operations.This function here basically consists out of nothing and assuming there are no weird optimizations related to knowing the called functions, only plain values produce the required order.
The only other way would be compiler differences, but these have lesser probability.
That being said, I would prefer if we could use some constants/macros for this with specific names. These here in the PR are only examples. I am open for better suggestions.