Implement extern symbols with name mangling#125
Merged
Conversation
gynt
changed the base branch from
main
to
experiment/use-asm-symbol-ref-for-structs
gynt
changed the base branch from
experiment/use-asm-symbol-ref-for-structs
to
main
gynt
force-pushed
the
refactor/extern-symbols
branch
from
fb292cd to
3cf5c79
Compare
TheRedDaemon
approved these changes
Jun 21, 2026
TheRedDaemon
left a comment
TheRedDaemon
left a comment
Contributor
There was a problem hiding this comment.
Awesome.
I will merge this and close my PR and do some clean ups on main directly.
This should really help us getting proper matching values when it comes to the functions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Achieved through ghidra-skink library update with a custom build MSVC1400 name mangling python library.
Covers all global defined data in the current project.
Tested by including all OpenSHC/Globals/*.hpp files in a single cpp file.
Renamed
game.asmtodata.asmbut I am open to suggestions. I suppose if we do more with asm in the feature we will add more asm files so I thoughtgame.asmwas a bit too generic of a name.This PR builds upon #116