Enable simplified display of serialized symbolic expressions - #211
Open
tbennun wants to merge 3 commits into
Open
Enable simplified display of serialized symbolic expressions#211tbennun wants to merge 3 commits into
tbennun wants to merge 3 commits into
Conversation
Contributor
Author
|
@phschaad please review if you can |
phschaad
self-requested a review
August 2, 2026 15:20
phschaad
requested changes
Aug 2, 2026
phschaad
left a comment
phschaad
left a comment
Collaborator
There was a problem hiding this comment.
Nice, thank you for the addition! Generally LGTM, but some smaller Q / nits.
Co-authored-by: Philipp Schaad <schaad.phil@gmail.com>
Contributor
Author
|
@phschaad I realized that version checking is actually unnecessary because normal symbolic expressions will be shown the same way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following spcl/dace#2366, symbolic expressions are now serialized with type-safety, but not always user-readable. We should display symbolic expressions in a simplified manner to avoid clutter.