feat: make gathered log directory configurable#29
Open
bdegeeter wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allow callers to configure where gathered machine logs are written.
matcher.LogDirremains a public package variable and defaults tologs, preserving the existing behavior for callers that do not configure it.Changes
matcher.LogDirconfiguration variable.os.MkdirAll.filepath.Join.Motivation
CI environments commonly require logs to be written directly into a designated artifact directory. Previously, gathered logs were always written to a hard-coded
logsdirectory.Compatibility
The default remains
logs, so existing users retain the current behavior unless they explicitly changematcher.LogDir.Validation
The following checks pass with Go 1.24.2:
go test ./...go test -race ./...go vet ./...git diff --checkUnit tests cover: