Clean Redis principal index during expiration cleanup#3798
Open
yeomin4242 wants to merge 1 commit into
Open
Conversation
When Redis expiration events are unavailable, the expires key may be gone while the session hash remains available in the grace period. Clean the principal index during the existing expiration cleanup flow when that session is already expired. Addresses spring-projectsgh-1715. Signed-off-by: YeongJae Min <whereismysejong@naver.com>
spring-projects-issues
added
the
status: waiting-for-triage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Redis expiration events are unavailable, the expires key may be gone while the session hash remains available in the grace period. Clean the principal index during the existing expiration cleanup flow when that session is already expired.
Summary
sessions:expires:<sessionId>is already gone while the session hash is still available and expiredRedisStaticMasterReplicaConfigurationAddresses gh-1715.
Notes
This keeps the cleanup in
RedisIndexedSessionRepository's expiration cleanup path. It does not changefindByIndexNameAndIndexValue, so index lookups do not gain cleanup side effects.The cleanup only removes the principal index entry when the session hash can still be loaded and the session is already expired. If the session hash is no longer available, this change leaves the index entry untouched.
This PR does not change
SortedSetRedisSessionExpirationStorebehavior.