Avoid freeze export during car charging sessions if export more solar is on#4134
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an interaction between the “export more solar” optimisation pass and EV charging: it prevents the optimiser from converting an idle export window into a freeze export window when that window overlaps a scheduled car charging slot (unless the configuration allows the car to charge from the battery).
Changes:
- Update
optimise_solar()to skip enabling freeze export (export limit99.0) on idle export windows that intersect a car charging slot whencar_charging_from_batteryis disabled. - Extend the optimise-solar test harness to configure car charging slots and the
car_charging_from_batteryflag. - Add targeted tests verifying overlap handling (blocked vs allowed when charging-from-battery is enabled).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| apps/predbat/plan.py | Prevents “export more solar” from enabling freeze export over EV charging slots unless EV charging-from-battery is enabled. |
| apps/predbat/tests/test_optimise_solar.py | Adds EV overlap scenarios to validate the new optimiser behaviour and the charging-from-battery exception. |
springfall2008
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.