Render the PostgreSQL DOMAIN type in autogenerate#1831
Open
cycsmail wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #1360
Autogenerate had no renderer for the PostgreSQL
DOMAINtype, so_repr_type()fell back to plainrepr(). That dropped every constructor argument except name/data_type and left the underlying type unqualified (e.g.DOMAIN('email', CITEXT(), check="...")rendered aspostgresql.DOMAIN('email', CITEXT())), silently losing thecheckconstraint.Adds
_render_DOMAIN_typetoPostgresqlImpl(whichrender_typealready dispatches to via_render_<visit_name>_type). It renders the name, the underlyingdata_typethroughrender._repr_typefor the right prefix/import, and each ofcollation,default,constraint_name,not_null,check,create_typeonly when it differs from its default. The issue's column now renders as:Tests are guarded by
config.requirements.sqlalchemy_2sinceDOMAINonly exists on SQLAlchemy 2.0+. With the source change stashed both new tests fail (missing prefix and kwargs); with the fix they pass.pytest -q -k domain→ 2 passed, andtests/test_postgresql.py tests/test_autogen_render.py→ 249 passed, 2 skipped. Lint clean on the changed files.