fix(trino): Backport airlift/airlift#1943 for max response header size#1510
Merged
Conversation
f287ad7 to
ebb343b
Compare
Member
|
There was an upstream review, which is great! I would suggest to wait with merging this until the upstream PR is merged or sufficient time is passed without review feedback. |
…/github.com/stackabletech/docker-images into feat/trino-airlift-http-response-size-patch
Member
Author
|
@sbernauer The patch has been merged upstream, I updated the patch here so it also includes the |
sbernauer
reviewed
May 28, 2026
sbernauer
approved these changes
May 28, 2026
Member
sbernauer
left a comment
There was a problem hiding this comment.
There was an ask for a test upstream, I let you decide if you want to wait with merge until we figured that out
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport airlift/airlift#1943 into the Airlift dependency shipped with Trino, so Jetty actually honours the configured max response header size (calls
setMaxResponseHeaderSizein addition tosetResponseHeaderSize).To do that, a new
trino/airliftimage is added that builds Airlift from source and applies the patch. The existingtrino/trinobuild then uses this patched Airlift instead of the original dependency.Two Airlift versions are patched, matching what Trino expects:
361for Trino477386for Trino479Once airlift/airlift#1943 is merged and Trino picks up a new Airlift release that contains the fix, the entire
trino/airliftdirectory and theairlift-builderstage intrino/trino/Dockerfilecan be removed again.Smoke test passes:
Definition of Done Checklist
TIP: Running integration tests with a new product image
The image can be built and uploaded to the kind cluster with the following commands:
See the output of
boilto retrieve the image manifest URI for<MANIFEST_URI>.