chore: Sync the vendored UI with upstream antora-ui-default, part 1: clean ports - #906
Open
lfrancke wants to merge 64 commits into
Open
chore: Sync the vendored UI with upstream antora-ui-default, part 1: clean ports#906lfrancke wants to merge 64 commits into
lfrancke wants to merge 64 commits into
Conversation
✅ Deploy Preview for stackable-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
|
lfrancke
force-pushed
the
phase3/clean-ports
branch
from
July 29, 2026 08:47
2c4cea5 to
12a5ec0
Compare
* float-group establishes a block formatting context (without affecting margin collapsing) * float-gap adds side and bottom margin to a floating element
…ss and display version is default
… Asciidoctor default stylesheet
…oth scroll Manual port of upstream antora-ui-default commit aac2ae9 (the patch does not apply verbatim because our load handler signature drifted). Belongs with f51a4e0 (enable smooth scroll by default), which this batch also ports: without it, the on-load fragment jump animates from the top of every page.
Upstream's breadcrumb-truncation script arrived as 07-breadcrumbs.js; our search script already used the 07- prefix. The bundle concatenates the numbered scripts in sorted order and the two are independent, so this only restores the one-number-one-script convention. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…e CLA The vendored UI is a fork of the MPL-2.0-licensed Antora Default UI and periodically ports upstream commits with their authorship preserved. Those authors have not signed the Stackable CLA; their code is included under the MPL-2.0 alone. Document this in ui/NOTICE and ui/README.adoc so provenance is clear for anyone doing due diligence, and note that the CLA check on port PRs (like this one) fails by design and needs an admin override. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
lfrancke
force-pushed
the
phase3/clean-ports
branch
from
August 5, 2026 20:35
d1de84e to
40ac14d
Compare
lfrancke
marked this pull request as ready for review
August 5, 2026 20:35
xeniape
requested changes
Aug 11, 2026
xeniape
left a comment
xeniape
left a comment
Member
There was a problem hiding this comment.
LGTM, one minor thing:
The commits here change the styling a bit, we override some of those in ui/src/css/admonition.css for example. There are now two dead code places in there due to the changes: lines 13-15 and lines 34-36.
This breaks the styling for them, example here: https://deploy-preview-906--stackable-docs.netlify.app/home/stable/contributor/code-style-guide/#_cargo_toml (the green/red boxes).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We based our UI on the Antora default UI but have not caught up with fixes that have landed there for four or so years 🥳
So, this is PR basically takes a lot of the missing commits (some come later in separate PRs due to conflicts etc.) and integrates them here.
Most of these are just "fixes" for stuff we don't see, but there are a few things that are user-visible here:
We skipped a few upstream commits which are relevant only for other fonts or styles where we diverged on purpose. Some of that will come in later PRs.
Important
I'd like a review on this but I'll need to force merge anyway because of the (obviously) missing CLAs. There is a note about this in this PR