fix: rewrite limit / offset - #16
Merged
Merged
Conversation
lfrancke
requested changes
Jul 24, 2026
| /// - PostgreSQL type names are normalized to Trino equivalents | ||
| /// - `ILIKE` becomes `lower(x) LIKE lower(pattern)` | ||
| /// - PostgreSQL function names are mapped to Trino equivalents | ||
| /// - `LIMIT n OFFSET m` is reordered into Trino order |
Member
There was a problem hiding this comment.
We also list the rewrites we do in the README and AGENTs file. We should either remove that stuff or update it.
| query.fetch = Some(Fetch { | ||
| with_ties: false, | ||
| percent: false, | ||
| quantity: Some(limit), |
Member
There was a problem hiding this comment.
Can you check whether/how Trino handles the edge case "0" here?
Member
Author
There was a problem hiding this comment.
you are right, this did cause an error and thank you for noticing - addressed in 056053d
lfrancke
moved this from Development: Waiting for Review
to Development: In Review
in Stackable Engineering
lfrancke
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.