feat: Enable auto-purge and set defaults - #1068
Conversation
|
I added the change as BREAKING in the changelog, but not sure. My reasoning was that it changes behavior, which might impact users and their assumptions of the data directory state. But if someone objects to that, that's fine too. |
|
I think BREAKING is fine. We want to point people at behavior that can delete data, even if it's only old journals. |
|
Yeah, that was the plan after it gets approved and the exact changes are set |
Release NoteWith the default settings, this means, that every 6 hours a cleanup runs, which checks for snapshots and their related transaction logs and only keeps the 3 most recent ones, the remaining ones are deleted. This mitigates the data directory filling up the PersistentVolume. More on the process, check the docs and for the defaults the reference. |
Description
Implementation for #1029
This PR only sets default values for the properties
autopurge.snapRetainCount,autopurge.purgeInterval(this one basically enables auto-purge),snapSizeLimitInKb, andpreAllocSize. The bulk of the PR is the additional docs explaining the feature and adding a reference page for the defaults.Verified that this feature works with a local kind cluster load test with smaller values. Snapshots were successfully deleted except for the 3 we keep.
Integrationtests
Definition of Done Checklist
Author
Reviewer
Acceptance
type/deprecationlabel & add to the deprecation scheduletype/experimentallabel & add to the experimental features tracker