fix(core): Array matcher missing deep equality - #176
Open
JoseLion wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the missing deep equality on the following matchers of
ArrayAssertion:toHaveSameMembers(expected: T[])toContainAll(...values: T[])toContainAny(...values: T[])Additionally, it adds a
Predicate<T>utility type and the newpredicates.tshelper file, intended for generic predicate builders that can help make the code more readable, maintainable, and functional. So far, this helper has only two predicate builders:deepEquals<A, B>(second: B) => Predicate<A>notDeepEquals<A, B>(second: B) => Predicate<A>