Skip to content

Label-Based resource ownership - ALB and Certificates #1145

Closed
meneksece wants to merge 8 commits into
feat/kp/add-alb-ingress-controllerfrom
feat/mc/add-alb-ingress-controller-resource-ownership-labels
Closed

Label-Based resource ownership - ALB and Certificates #1145
meneksece wants to merge 8 commits into
feat/kp/add-alb-ingress-controllerfrom
feat/mc/add-alb-ingress-controller-resource-ownership-labels

Conversation

@meneksece
Copy link
Copy Markdown

@meneksece meneksece commented May 22, 2026

How to categorize this PR?

What this PR does / why we need it:

This PR introduces structured ownership for Application Load Balancer (ALB) and Certificate resources. By using a consistent labeling system based on the IngressClass UID, the controller can now easily find and clean up the resources of ALB and Certificate it created.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Key Changes:

Ownership Labeling: Introduced LabelIngressClassUID (prefixed with alb-ingress-controller-) to track resource provenance.

Label Addition: Added logic in getAlbSpecForResources to include the ownership label to the alb spec.

Extended Interface: Updated applyCertificates to accept the IngressClass object to ensure certificates are also labeled upon creation.

Breaking changes:

-->

ske-renovate-ce Bot and others added 8 commits May 20, 2026 23:40
Co-authored-by: ske-renovate-ce[bot] <163154779+ske-renovate-ce[bot]@users.noreply.github.com>
…ancer to v1.13.0 (#1104)

Co-authored-by: ske-renovate-ce[bot] <163154779+ske-renovate-ce[bot]@users.noreply.github.com>
Co-authored-by: ske-renovate-ce[bot] <163154779+ske-renovate-ce[bot]@users.noreply.github.com>
Co-authored-by: ske-renovate-ce[bot] <163154779+ske-renovate-ce[bot]@users.noreply.github.com>
Co-authored-by: ske-renovate-ce[bot] <163154779+ske-renovate-ce[bot]@users.noreply.github.com>
Co-authored-by: ske-renovate-ce[bot] <163154779+ske-renovate-ce[bot]@users.noreply.github.com>
Co-authored-by: ske-renovate-ce[bot] <163154779+ske-renovate-ce[bot]@users.noreply.github.com>
added tests for resource ownership label
for certificate and alb resources
@ske-prow ske-prow Bot added the breaking This PR contains a breaking change and should be listed accordingly in release notes. label May 22, 2026
@ske-prow
Copy link
Copy Markdown

ske-prow Bot commented May 22, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kumm-kai for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ske-prow ske-prow Bot added do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 22, 2026
@meneksece meneksece removed the breaking This PR contains a breaking change and should be listed accordingly in release notes. label May 22, 2026
@meneksece meneksece changed the base branch from main to feat/kp/add-alb-ingress-controller May 22, 2026 13:29
@ske-prow
Copy link
Copy Markdown

ske-prow Bot commented May 22, 2026

@meneksece: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cloud-provider-stackit-verify 4eb2b4e link true /test pull-cloud-provider-stackit-verify

Full PR test history. Your PR dashboard. Command help for this repository.
Please help us cut down on flakes by linking this test failure to an open flake report or filing a new flake report if you can't find an existing one. Also see the gardener testing guideline for how to avoid and hunt flakes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ske-prow ske-prow Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 22, 2026
@meneksece meneksece changed the title Feat/mc/add alb ingress controller resource ownership labels Label-Based resource ownership - ALB and Certificates May 22, 2026
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd just delete this file entirely, it's commented out and test cases are outdated

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to keep it since we are planning soon to re-introduce them, even though some tests are outdated, the setup will be helpful instead of starting over.

@meneksece meneksece added the kind/enhancement Enhancement, improvement, extension label May 26, 2026
@ske-prow ske-prow Bot removed the do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. label May 26, 2026
@meneksece meneksece closed this May 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/enhancement Enhancement, improvement, extension size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants