Skip to content

Minor improvement to fail message of metrics verification (used for troubleshooting) #2103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tatu-at-datastax merged 1 commit into from
May 28, 2025
Merged

Minor improvement to fail message of metrics verification (used for troubleshooting) #2103

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/test/java/io/stargate/sgv2/jsonapi/api/v1/AbstractKeyspaceIntegrationTestBase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
import static org.assertj.core.api.Assertions.assertThat;
import static org.hamcrest.Matchers.is;
import static org.hamcrest.Matchers.nullValue;
import static org.junit.jupiter.api.Assertions.fail;

import com.datastax.oss.driver.api.core.CqlSession;
import com.datastax.oss.driver.api.core.CqlSessionBuilder;
Expand Down Expand Up @@ -244,7 +245,15 @@ public static void checkDriverMetricsTenantId() {
line ->
line.startsWith("session_cql_requests_seconds") && line.contains("session="))
.findFirst();
assertThat(sessionLevelDriverMetricTenantId.isPresent()).isTrue();
if (!sessionLevelDriverMetricTenantId.isPresent()) {
List<String> lines = metrics.lines().toList();
long buckets =
lines.stream().filter(line -> line.startsWith("session_cql_requests_seconds")).count();
fail(
String.format(
"No tenant id found in any of 'session_cql_requests_seconds' entries (%d buckets; %d log lines)",
buckets, lines.size()));
}
}

public static void checkVectorMetrics(String commandName, String sortType) {
Expand Down