Diagnostics - #292
Open
sipma wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a diagnostic code to error and warning log messages, to enable downstream users to decide what action to take in response to these messages. The diagnostic codes introduced are:
In this PR only about a quarter of the (some 200) messages have been converted so far to report this diagnostic. Over time all error/warning messages will be converted, is the plan.
Furthermore, a new error message (with diagnostic code TYPING) has been added that will be raised whenever a lifting is produced that includes one or more untyped local variables. However, this will only be reported when there are no other errors reported (to reduce the noise).