Skip to content

feat: add C implementation for blas/base/csscal#12314

Merged
kgryte merged 10 commits into
stdlib-js:developfrom
MeKaustubh07:blas/base/csscal
May 28, 2026
Merged

feat: add C implementation for blas/base/csscal#12314
kgryte merged 10 commits into
stdlib-js:developfrom
MeKaustubh07:blas/base/csscal

Conversation

@MeKaustubh07
Copy link
Copy Markdown
Member


type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:

  • task: lint_filenames status: passed
  • task: lint_editorconfig status: passed
  • task: lint_markdown status: passed
  • task: lint_package_json status: passed
  • task: lint_repl_help status: passed
  • task: lint_javascript_src status: passed
  • task: lint_javascript_cli status: na
  • task: lint_javascript_examples status: passed
  • task: lint_javascript_tests status: passed
  • task: lint_javascript_benchmarks status: passed
  • task: lint_python status: na
  • task: lint_r status: na
  • task: lint_c_src status: missing_dependencies
  • task: lint_c_examples status: missing_dependencies
  • task: lint_c_benchmarks status: missing_dependencies
  • task: lint_c_tests_fixtures status: na
  • task: lint_shell status: na
  • task: lint_typescript_declarations status: passed
  • task: lint_typescript_tests status: na
  • task: lint_license_headers status: passed ---

Resolves #{{TODO: add issue number}}.

Description

What is the purpose of this pull request?

This pull request:

  • feat: add C implementation for blas/base/csscal

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

  • #{{TODO: add related issue number}}

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

{{TODO: add disclosure if applicable}}


@stdlib-js/reviewers

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: passed
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: missing_dependencies
  - task: lint_c_examples
    status: missing_dependencies
  - task: lint_c_benchmarks
    status: missing_dependencies
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@MeKaustubh07 MeKaustubh07 requested a review from a team May 27, 2026 09:09
@stdlib-bot stdlib-bot added BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Needs Review A pull request which needs code review. labels May 27, 2026
@MeKaustubh07 MeKaustubh07 added GSoC Google Summer of Code. gsoc: 2026 Google Summer of Code (2026). labels May 27, 2026
@MeKaustubh07 MeKaustubh07 requested a review from gunjjoshi May 27, 2026 09:11
@stdlib-bot
Copy link
Copy Markdown
Contributor

stdlib-bot commented May 27, 2026

Coverage Report

Package Statements Branches Functions Lines
blas/base/csscal $\color{green}375/375$
$\color{green}+0.00%$
$\color{green}18/18$
$\color{green}+0.00%$
$\color{green}4/4$
$\color{green}+0.00%$
$\color{green}375/375$
$\color{green}+0.00%$

The above coverage report was generated for the changes in this PR.

@kgryte kgryte added Feature Issue or pull request for adding a new feature. C Issue involves or relates to C. difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. review: 5 and removed Needs Review A pull request which needs code review. labels May 27, 2026
Comment thread lib/node_modules/@stdlib/blas/base/csscal/benchmark/c/benchmark.length.c Outdated
Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
Comment thread lib/node_modules/@stdlib/blas/base/csscal/benchmark/c/benchmark.length.c Outdated
Comment thread lib/node_modules/@stdlib/blas/base/csscal/manifest.json Outdated
Comment thread lib/node_modules/@stdlib/blas/base/csscal/manifest.json Outdated
Comment thread lib/node_modules/@stdlib/blas/base/csscal/README.md Outdated
Signed-off-by: Athan <kgryte@gmail.com>
Copy link
Copy Markdown
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left initial comments. Also, as a reminder, please don't update copyright years of existing files. I discarded a number of spurious copyright year changes in this PR.

@kgryte kgryte added review: 3 Needs Changes Pull request which needs changes before being merged. and removed review: 5 labels May 27, 2026
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@MeKaustubh07
Copy link
Copy Markdown
Member Author

Left initial comments. Also, as a reminder, please don't update copyright years of existing files. I discarded a number of spurious copyright year changes in this PR.

Understood.

@MeKaustubh07 MeKaustubh07 added Needs Review A pull request which needs code review. and removed Needs Changes Pull request which needs changes before being merged. labels May 28, 2026
@kgryte kgryte removed the Needs Review A pull request which needs code review. label May 28, 2026
Comment thread lib/node_modules/@stdlib/blas/base/csscal/README.md
@kgryte kgryte added the Needs Changes Pull request which needs changes before being merged. label May 28, 2026
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: missing_dependencies
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@MeKaustubh07 MeKaustubh07 added Needs Review A pull request which needs code review. and removed Needs Changes Pull request which needs changes before being merged. labels May 28, 2026
@MeKaustubh07 MeKaustubh07 requested a review from kgryte May 28, 2026 09:22
@kgryte kgryte removed the Needs Review A pull request which needs code review. label May 28, 2026
@kgryte kgryte merged commit af6a5d7 into stdlib-js:develop May 28, 2026
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). C Issue involves or relates to C. difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. Feature Issue or pull request for adding a new feature. GSoC Google Summer of Code. gsoc: 2026 Google Summer of Code (2026). review: 3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants