Skip to content

feat: add fft/base/fftpack/ndarray/rffti#13527

Draft
gunjjoshi wants to merge 2 commits into
stdlib-js:developfrom
gunjjoshi:ndarray/rffti
Draft

feat: add fft/base/fftpack/ndarray/rffti#13527
gunjjoshi wants to merge 2 commits into
stdlib-js:developfrom
gunjjoshi:ndarray/rffti

Conversation

@gunjjoshi

@gunjjoshi gunjjoshi commented Jul 18, 2026

Copy link
Copy Markdown
Member

type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:

  • task: lint_filenames status: passed
  • task: lint_editorconfig status: passed
  • task: lint_markdown_pkg_readmes status: na
  • task: lint_markdown_docs status: na
  • task: lint_markdown status: na
  • task: lint_package_json status: na
  • task: lint_repl_help status: na
  • task: lint_javascript_src status: passed
  • task: lint_javascript_cli status: na
  • task: lint_javascript_examples status: na
  • task: lint_javascript_tests status: na
  • task: lint_javascript_benchmarks status: na
  • task: lint_python status: na
  • task: lint_r status: na
  • task: lint_c_src status: na
  • task: lint_c_examples status: na
  • task: lint_c_benchmarks status: na
  • task: lint_c_tests_fixtures status: na
  • task: lint_shell status: na
  • task: lint_typescript_declarations status: passed
  • task: lint_typescript_tests status: na
  • task: lint_license_headers status: passed ---

Resolves stdlib-js/metr-issue-tracker#1070.

Description

What is the purpose of this pull request?

This pull request:

  • adds fft/base/fftpack/ndarray/rffti, which will be the one-dimensional ndarry wrapper for fft/base/fftpack/rffti.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

Used Gemini 3.5 Flash to search and understand working of ndarray wrappers.

@stdlib-js/reviewers

@gunjjoshi
feat: add initial implementation
030a34a 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown_pkg_readmes
    status: na
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@gunjjoshi gunjjoshi added the METR Pull request associated with the METR project. label Jul 18, 2026
@gunjjoshi

gunjjoshi commented Jul 18, 2026

Copy link
Copy Markdown
Member Author

Opening a draft PR to discuss the implementation here, since this seems to be a bit different from existing ndarray wrappers.

gunjjoshi
gunjjoshi commented Jul 18, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/fft/base/fftpack/ndarray/rffti/lib/main.js Outdated
gunjjoshi
gunjjoshi commented Jul 18, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/fft/base/fftpack/ndarray/rffti/lib/main.js
Comment on lines +72 to +80
function rffti( arrays ) {
var workspace;
var N;

N = ndarraylike2scalar( arrays[ 0 ] );
workspace = arrays[ 1 ];
strided( N, getData( workspace ), getStride( workspace, 0 ), getOffset( workspace ) ); // eslint-disable-line max-len
return workspace;
}

@gunjjoshi gunjjoshi Jul 18, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't directly send numelDimension( workspace, 0 ) here, as the length of the sequence to transform (N) is different from the size of the workspace array (2*N + 34).

@gunjjoshi

gunjjoshi commented Jul 18, 2026

Copy link
Copy Markdown
Member Author

@kgryte Let me know if the above looks good, or if I should make any changes here. I'll work on adding other files meanwhile.

@gunjjoshi
refactor: use ndarray/slice
60f690c 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown_pkg_readmes
    status: na
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kgryte kgryte kgryte left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

METR Pull request associated with the METR project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[RFC]: add fft/base/fftpack/ndarray/rffti

2 participants

@gunjjoshi @kgryte