Sandbox to Master - #52
Merged
Merged
Conversation
Allow the PFC to proxy ("write-through") writes when configured
to do so (default is current behavior of disabling writes).
The implementation is simple -- when writing is enabled, don't
attach the PFC to the cache object.
Adds a new parameter:
```
pfc.writemode [writethrough | off]
```
where the default write mode is `off`.
This can be useful e.g. for Xcache proxy to allow it to redirect incoming write requests to the origin.
Tokens are created during XRootD::scitokens::setup, and the tests are run in XRootD::scitoken::test. If the token lifetime is too short, the scheduling of tests may be such that some long running tests are run in between XRootD::scitokens::setup and XRootD::scitoken::test, which then makes it likely that the token will be already expired when the actual test starts, leading to errors in the CI.
…tial response to a TPC copy
This function iterates over pSources without taking the required pMtx lock, so the iterator can become stale if the list is modified by another thread, causing a crash. Fixes: xrootd#2659
After increasing the timeouts in commit 9f18c52, the tests work most of the time. However, there are still occasional failures due to timeouts. There are two types of errors: 1. Run: [ERROR] Socket timeout: (destination) This is the XRD_STREAMTIMEOUT (currently set to 5 seconds) expiring. 2. Run: [ERROR] Operation expired: (destination) This is the XRD_REQUESTTIMEOUT (currently set to 10 seconds) expirin.g This commit increases the timeouts to 10 and 15 seconds respectively.
…ow deleting object from a base class pointer
This adds constructors to allow initliasing the XrdCl::File plugins without having to call Open on the file.
Needed for compilation on GNU/Hurd. Possibly there are better solutions, but this is consistent with the implementation in src/XrdSys/XrdSysPthread.cc
…e minor bugs (xrootd#2775) This introduces improved support for links in XrdPosix, specifically for XrdPosixPreload. Current override functions for stat, statx, open etc do check if the current file is to be handled by xrootd or not. If the file is a local link pointing to e.g. EOS, these functions should resolve the link location and check the target rather than the local link itself (exception: lstat). In addition, this patch introduces overrides for openat and fstatat (albeit they are likely not used much), and implements a few minor bug fixes.
Fixes test failure with Debian on sparc64
…dResolveLink
Fixes a bug reported by Coverity about the buffer potentially
not being null-terminated:
while (lsize > 0 && i<10){
CID 503592: (#1 of 1): Buffer not null terminated (BUFFER_SIZE)
11. buffer_size_warning: Calling strncpy with a maximum size argument of 2049 bytes
on destination array filename of size 2049 bytes might leave the destination string
unterminated.
129 strncpy(filename, unref, 2049);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.