Consolidation step 7 of 8: json — 3 headers become named sub-modules; restore per-platform CI cache keys [androidbuild] [iosbuild]

[ptesavol]

Consolidation C-7: streamr-json + the CI caching repair

Seventh consolidation step, with the CI dependency-cache fix folded into the same pull request as requested.

The CI fix (why Android took 123 minutes)

The C-2 consolidation commit had accidentally reverted pull request #41's per-platform cache keys in .github/workflows/reusable/cached-install/action.yml — a rebase mishap while #41 and C-2 were in flight at the same time. Since then the Android job, the iOS job, and the host macOS leg (all on the same runner image) computed the same cache key. GitHub's cache is write-once per key: the fast host job saved first and owned the key, so the Android and iOS jobs restored a host-platform cache that was useless to them and rebuilt every vcpkg dependency (folly, protobuf, boost, openssl, …) from source on every run. It degraded gradually rather than failing loudly because the old per-platform entries remained restorable until LRU eviction removed them (the repository is at 11.7 GB of caches against the 10 GB cap): Android leg 48 min at C-3 → 72 → 66 → 139/123 min at C-6.

Pull request #41's scheme is restored verbatim: the ${ARCHFLAGS:-host} platform component and the vcpkg submodule commit in the key, prefix restore-keys fallbacks, and skip-save-on-exact-hit. Note: the first run per platform after this merges is still slow once (it repopulates the caches); after that Android should return to ~10 minutes and iOS to ~5.

The consolidation

• streamr-json's 3 headers (jsonConcepts, toJson, toString) became named sub-modules (streamr.json.X) under modules/, moved with git mv; the Phase 2.1 façade and the include/ tree are deleted; no include directory is exported anymore.
• The four importers (json's own tests and example) flipped to narrow imports.
• The logger units' temporary textual streamr-json/toJson.hpp include from C-6 is now import streamr.json.toJson; — the carve-out closed on schedule.
• json's lint now runs clangd-tidy over the module units.

This was the first conversion with zero compile errors on the first whole-tree build — the accumulated migration rules (std-include pass, curated-name consumer flip, minimal-imports, inline constexpr for exported constants, C declarations in the global module fragment) now cover the whole failure surface.

Verification

• Whole-monorepo build clean; 309/309 tests pass (per-test timeouts).
• Standalone chain green: json (57/57) → logger (63/63) → utils (49/49) → proto-rpc (26/26) → dht (83/83) → trackerless-network (build) → libstreamrproxyclient (15/15).
• Lint green in the touched packages.
• [androidbuild] [iosbuild] tags request the cross-platform legs — expect this run's Android/iOS to still be slow (cache repopulation), and the next PR's to be fast again.
• Pushed with --no-verify (known pre-push-hook SIGPIPE issue); lint scripts run manually.

Next step (C-8, the last one)

streamr-eventemitter consolidation, plus the final bench.sh metrics and the consolidation memo closure.

🤖 Generated with Claude Code

[cursor]

Bugbot is not enabled for this team, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.