This repository was archived by the owner on Feb 4, 2023. It is now read-only.
Locale aware for datefilter#640
Open
nicodmf wants to merge 4 commits into
Open
Conversation
Contributor
Author
|
@stwe ping :) |
Contributor
Author
|
ping @stwe |
Contributor
Author
|
@Seb33300 ping |
Collaborator
|
I think the filter should depend on the related column date format, not on the locale. |
Contributor
Author
|
Yes you're right, but this locale choice doesn't break that, it's just take the date from the locale format used by client, or whatever the developper configure. If the client format in french, the developper can take the actual local and take the date in french, if the client format in english, it take the format in english. Actually, the datefilter range cannot tale a french date by exemple. |
Contributor
Author
|
@Seb33300 ping we have many improvement in this essential bundle, can you see and work it ? |
Co-Authored-By: Stephan Vierkant <stephan@vierkant.net>
Contributor
Author
|
@stephanvierkant thanks for reviewing, a fix made in january is just a non sense and we should surelly commit a better locale intégration |
nicodmf
referenced
this pull request
Jun 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.