feat(isthmus): observe window function return types - #1059
Open
alexandrefimov wants to merge 2 commits into
Open
feat(isthmus): observe window function return types#1059alexandrefimov wants to merge 2 commits into
alexandrefimov wants to merge 2 commits into
Conversation
Report Calcite-inferred window return types through the existing observer while preserving the Substrait-supplied RexOver type. Keep the NOOP fast path and convert inference failures into observations.
Allow callers to install a type observer without subclassing ConverterProvider.
alexandrefimov
force-pushed
the
issue-379-window-type-observer
branch
from
August 4, 2026 03:32
3f70f98 to
fa97d02
Compare
alexandrefimov
marked this pull request as ready for review
August 4, 2026 03:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TypeObserverduring window-function conversionTypeObserver.NOOPConverterProvider.BuilderMotivation
Scalar-function type observation was introduced in #1015. Issue #379 also identifies window functions as a conversion point where Substrait-supplied and Calcite-inferred types can diverge. This change extends the same observation side channel to window functions and makes it available without subclassing
ConverterProvider.Validation
./gradlew :isthmus:spotlessCheck :isthmus:test --tests 'io.substrait.isthmus.ConverterProviderBuilderTest' --tests 'io.substrait.isthmus.SubstraitExpressionConverterTest' :isthmus:javadoc./gradlew build --rerun-tasksRelated to #379.