Skip to content

chore(tooling): migrate to Vite+ - #19

Merged
caio-pizzol merged 2 commits into
mainfrom
caio/vite-plus-migration
Aug 12, 2026
Merged

chore(tooling): migrate to Vite+#19
caio-pizzol merged 2 commits into
mainfrom
caio/vite-plus-migration

Conversation

@caio-pizzol

Copy link
Copy Markdown
Contributor

Summary

  • migrate web development and builds to Vite+ 0.2.9
  • replace Biome and Lefthook with Vite+ formatting, linting, staged checks, and Git hooks
  • upgrade to TypeScript 7.0.2 with one strict base config and project-specific settings
  • keep Bun as the package manager and test runner, and keep Wrangler for the MCP Worker
  • update CI, deploy, release, and development commands to use the pinned Vite+ installer

Why

This gives the workspace one tool for the web build, static checks, workspace tasks, and hooks. Bun remains in place where the project depends on its runtime, especially the bun:test suites.

The formatter ignores existing files that Biome did not manage. This avoids mixing a broad formatting rewrite into the tooling migration.

Verification

  • bunx --package vite-plus@0.2.9 vp install --frozen-lockfile
  • bun run check
  • bun run test — 108 passed, 4 cache-dependent smoke tests skipped
  • bun test tests/scripts/db-migrate.test.ts — 5 passed
  • bun run build
  • bun run --cwd apps/mcp-server build
  • bare root vp build
  • vp staged in a scratch Git repository
  • Vite+ hooks with development dependencies absent

One existing unused-import warning remains in scripts/ingest-xsd/ingest.ts.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8b9905ca04

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread package.json

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 28 files

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread .vite-hooks/pre-commit
Comment thread .vite-hooks/pre-push
@caio-pizzol
caio-pizzol force-pushed the caio/vite-plus-migration branch from 8b9905c to 206cdd4 Compare August 12, 2026 21:15
@caio-pizzol
caio-pizzol enabled auto-merge (squash) August 12, 2026 21:16
@caio-pizzol
caio-pizzol merged commit 3e8b063 into main Aug 12, 2026
2 checks passed
@caio-pizzol
caio-pizzol deleted the caio/vite-plus-migration branch August 12, 2026 21:17
@caio-pizzol

Copy link
Copy Markdown
Contributor Author

@cubic-dev-ai review this PR after the rebase.

@cubic-dev-ai

cubic-dev-ai Bot commented Aug 12, 2026

Copy link
Copy Markdown

@cubic-dev-ai review this PR after the rebase.

@caio-pizzol I have started the AI code review. It will take a few minutes to complete.

@linear-code

linear-code Bot commented Aug 12, 2026

Copy link
Copy Markdown

SD-4210

@qodo-code-review

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (1) 📘 Rule violations (0) 📜 Skill insights (0)



View medium (1)
🟠 **Medium**
1. Hook failures are masked 🐞
Description
The pre-commit hook continues after vp staged or bun run typecheck fails and returns only the
final web build's status. A successful web build therefore permits the commit even when staged
checks fail or MCP/shared code does not type-check.
Code

.vite-hooks/pre-commit[R5-7]

+vp staged
+bun run typecheck
+bun run build
Relevance

●●● Strong

Team often accepts “fail fast/guard against silent success” reliability fixes; hook should propagate
earlier failures.

PR-#20
PR-#17

ⓘ Recommendations generated based on similar findings in past PRs

Evidence
The hook is a sequential command list without set -e or &&, so its exit status comes from the
final command. The root typecheck covers all @ooxml-dev/* workspaces, while the final build
targets only @ooxml-dev/web, proving that an MCP/shared typecheck failure can be followed and
masked by a successful web build.

.vite-hooks/pre-commit[5-7]
package.json[13-19]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The pre-commit hook runs validation commands independently, so a successful final build masks earlier failures and allows an invalid commit.

## Issue Context
Use `set -e` or chain the commands with `&&` so the hook exits nonzero on the first failed staged check, typecheck, or build.

## Fix Focus Areas
- .vite-hooks/pre-commit[5-7]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools



Context
Review mode: 🧠 Deep: This is a broad tooling, dependency, TypeScript, build, CI, hook, and workspace-task migration with many independent behavior changes and substantial setup/deploy blast radius, making multiple review passes materially useful.

Tip of the day
💡 Did you know, you can enable the Remediation agent and Qodo fixes findings in a dedicated fix PR

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗


Powered by Qodo

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 28 files

Re-trigger cubic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants