chore: merge main into version-1 - #1196
Open
jycouet wants to merge 5 commits into
Open
Conversation
* main * throw if pm isnt installed * throw * nit * changeset * tmv sv ordering * sh is unknwon on windows (execSync know about it) * hint to label & next step * caching agent install, keep none by default --------- Co-authored-by: jycouet <jycouet@gmail.com>
Bump package-manager-detector to ^1.8.0, the first release with nub in its agent and command tables. sv-utils bundles the library at build time, so the published bundle only knows about nub once rebuilt against >=1.8.0.
) When prettier is among the scaffolded add-ons, format the whole project rather than only the add-on-touched files, so a fresh project passes its own lint. Prettier's ignore rules still apply. Signed-off-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com> Co-authored-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com>
* feat: addOption in setup phase * fmt² * okay cut * humm * fmt * chore: update api surface * test: await async setupAddons in engine tests * Update packages/sv/src/core/config.ts Co-authored-by: Scott Wu <sw@scottwu.ca> * Update packages/sv/src/core/config.ts Co-authored-by: Scott Wu <sw@scottwu.ca> * feat: typesafe addOption keys via defineAddon setup generic - addOption now constrains key + question type from defineAddon<SetupValues>() - regenerate api surface --------- Co-authored-by: Scott Wu <sw@scottwu.ca>
Resolve conflicts: keep verkit-based semver utils and the v1 deprecation removals, keep main's smart package manager selection + `addOption` setup phase, and combine both format flows (skip formatting when install fails, keep the 'files-only' strategy).
|
Install the latest version of pnpm add https://pkg.svelte.dev/sv/c/3e4c2221e05e39d6dee59d7072bc5a68ff017605Open in |
🦋 Changeset detectedLatest commit: 3e4c222 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
will you set default branch to |
Contributor
Author
I'm not sure, we can still push to the 2 places? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings
main(4 commits) intoversion-1in a single merge commit.Conflict resolutions:
package-manager-detector@^1.8.0create/add: combine main's "skip formatting when install failed" with v1'sstrategy: 'files-only'svelte-migrateis a deprecated stub on v1, so its changeset entry and deps are dropped