fix: drop obsolete pnpm allowBuilds entries and surface real format errors - #1198
Open
jycouet wants to merge 2 commits into
Open
fix: drop obsolete pnpm allowBuilds entries and surface real format errors#1198jycouet wants to merge 2 commits into
jycouet wants to merge 2 commits into
Conversation
|
Install the latest version of pnpm add https://pkg.svelte.dev/sv/c/7e207374166c41c96f6ed9df688ad3abaa03f033Open in |
🦋 Changeset detectedLatest commit: 7e20737 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
This is currently targeting |
Contributor
Author
You think it should target |
Contributor
|
How do I decide which one to target? |
Contributor
Author
If it's related to kit3 or migration, I would say |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1141
Closes #1166
Description
allowBuildsfor@tailwindcss/oxideandsharp- neither ships an install script anymore (workerdandbetter-sqlite3still do, so they stay).prettierfromnode_modules/.bin(falling back to the package manager for Yarn PnP), and errors report stdout too. pnpm refuses to runpnpm execafter it writesset this to true or falseplaceholders on skipped builds, and it prints that on stdout, which surfaced asFailed to format files / unknown error.Checklist