Fix Subprocess.run API updates#775
Open
marcprux wants to merge 3 commits into
Open
Conversation
Contributor
Author
|
It looks like we'll also need to drop the I'm guessing this won't be an issue since we document Swift 6.2 as being the minimum required version in the README anyway. |
Contributor
Author
|
This is causing the swift-android-examples to fail to build with the errors: |
Contributor
Author
|
An alternative solution could be to pin |
…ly update to 1.0 once it is released
Collaborator
|
I’ll have to double check if we need 6.1 in some adopters… thank you for the pr! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the API breakage introduced in swift-subprocess 0.5 by swiftlang/swift-subprocess#233.