Skip to content

Improved docker-compose.yaml#149

Open
rselph wants to merge 3 commits into
synfinatic:mainfrom
rselph:docker-compose
Open

Improved docker-compose.yaml#149
rselph wants to merge 3 commits into
synfinatic:mainfrom
rselph:docker-compose

Conversation

@rselph

@rselph rselph commented Jan 10, 2026

Copy link
Copy Markdown

This docker-compose file offers a few advantages:

  • Doesn't use host network. This is a security improvement, and means that neither the redis port nor the zmq port need to be made public.
  • Persists redis data. This also prevents the redis container from creating an anonymous volume each time it is created.
  • Persists ntopng data
  • Sets timezone for ntopng
  • Expands local network definition
  • Enables DNS lookups

Copilot AI review requested due to automatic review settings June 19, 2026 18:35
@synfinatic

Copy link
Copy Markdown
Owner

@rselph can you sign your commits? probably easiest to rebase into a single commit and sign that.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the docker-compose.yaml setup to run netflow2ng, redis, and ntopng on a default bridged network (instead of host networking), while adding persistence and refining ntopng configuration.

Changes:

  • Replace network_mode: host with explicit port publishing for NetFlow (and ntopng UI) and internal service-to-service networking.
  • Persist Redis and ntopng state using named volumes.
  • Update ntopng runtime configuration (redis host, local networks, DNS mode, timezone).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread docker-compose.yaml
Comment thread docker-compose.yaml Outdated
@codecov

codecov Bot commented Jun 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (28fee3f) to head (3b89d18).

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #149   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files          7       7           
  Lines        656     656           
=====================================
  Misses       656     656           

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28fee3f...3b89d18. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

rselph and others added 3 commits June 19, 2026 19:34
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants