Editorial: reword description of Promise subclassing#3872
Open
michaelficarra wants to merge 1 commit into
Open
Editorial: reword description of Promise subclassing#3872michaelficarra wants to merge 1 commit into
michaelficarra wants to merge 1 commit into
Conversation
|
The rendered spec preview for this PR is available as a single page at https://tc39.es/ecma262/pr/3872 and as multiple pages at https://tc39.es/ecma262/pr/3872/multipage . |
linusg
approved these changes
May 18, 2026
Member
|
Similar phrasing, albeit with only the prototype, appears in ten other clauses (e.g. Map). I'd prefer we do the same edit in all of them. |
gibson042
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I kept misreading this, thinking the word "constructor" was missing from this sentence, forgetting that Promise static methods even existed. I've reworded it so it's not confusing.