Skip to content

fix(database): use correct return type for IsDatabaseModel::resolve#2178

Merged
brendt merged 2 commits into
3.xfrom
is-database-model-correct-return-type
Jun 22, 2026
Merged

fix(database): use correct return type for IsDatabaseModel::resolve#2178
brendt merged 2 commits into
3.xfrom
is-database-model-correct-return-type

Conversation

@brendt

@brendt brendt commented Jun 22, 2026

Copy link
Copy Markdown
Member

No description provided.

@brendt brendt requested a review from innocenzi as a code owner June 22, 2026 07:35
@brendt

brendt commented Jun 22, 2026

Copy link
Copy Markdown
Member Author

PhpStorm complains of self is used in a trait while the interface defines static. Making this change makes PHPStan complain, which I then suppresed. I think it's more important to have accurate realtime IDE support

@github-actions

Copy link
Copy Markdown

Benchmark Results

Comparison of is-database-model-correct-return-type against 3.x (452e201d6fc8a3994d3f987f0fbec3f6a743edd1).

Open to see the benchmark results

No benchmark changes above ±5%.

Generated by phpbench against commit f5b4abc

@brendt brendt merged commit b01cd64 into 3.x Jun 22, 2026
76 checks passed
@brendt brendt deleted the is-database-model-correct-return-type branch June 22, 2026 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant