Add regression test for WorkerFactory command-worker cleanup race#2952
Draft
eamsden wants to merge 1 commit into
Draft
Add regression test for WorkerFactory command-worker cleanup race#2952eamsden wants to merge 1 commit into
eamsden wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Added a deterministic regression test for #2951. The test completes command-worker shutdown after
WorkerFactory.awaitTerminationhas passed its null check, reproducing the cleanup race.Why?
The asynchronous shutdown continuation can clear
workerCommandWorkerbefore the termination callback dereferences it.Breaking changes
None.
Server PR
N/A.
Testing
The test fails as expected on current
mainwith the reportedNullPointerException. It passes when the asynchronousworkerCommandWorker = nullcleanup is removed.