Don't swallow stderr in gen_protos_docker#1145
Merged
Merged
Conversation
tconley1428
approved these changes
Oct 8, 2025
Contributor
Author
|
I don't have permissions to merge this btw. |
Sushisource
enabled auto-merge (squash)
October 10, 2025 17:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change allowed me to see the stderr (my docker storage was full).
Note
Low Risk
Local proto-generation helper only; no runtime or production behavior changes.
Overview
docker buildingen_protos_docker.pyno longer hides stderr. The subprocess call still pipes stdout so the image ID can be read, but replacescapture_output=Truewithstdout=subprocess.PIPEonly.When the build fails (e.g. disk full), Docker’s error output now appears in the terminal instead of being swallowed.
Reviewed by Cursor Bugbot for commit 0ba1da8. Bugbot is set up for automated code reviews on this repo. Configure here.