Skip to content

Don't swallow stderr in gen_protos_docker#1145

Merged
Sushisource merged 5 commits into
mainfrom
docker-gen-protos-stderr
Jul 21, 2026
Merged

Don't swallow stderr in gen_protos_docker#1145
Sushisource merged 5 commits into
mainfrom
docker-gen-protos-stderr

Conversation

@dandavison

@dandavison dandavison commented Oct 8, 2025

Copy link
Copy Markdown
Contributor

This change allowed me to see the stderr (my docker storage was full).


Note

Low Risk
Local proto-generation helper only; no runtime or production behavior changes.

Overview
docker build in gen_protos_docker.py no longer hides stderr. The subprocess call still pipes stdout so the image ID can be read, but replaces capture_output=True with stdout=subprocess.PIPE only.

When the build fails (e.g. disk full), Docker’s error output now appears in the terminal instead of being swallowed.

Reviewed by Cursor Bugbot for commit 0ba1da8. Bugbot is set up for automated code reviews on this repo. Configure here.

@dandavison
dandavison requested a review from a team as a code owner October 8, 2025 16:29
@dandavison

Copy link
Copy Markdown
Contributor Author

I don't have permissions to merge this btw.

@Sushisource
Sushisource enabled auto-merge (squash) October 10, 2025 17:29
@Sushisource
Sushisource merged commit 615122d into main Jul 21, 2026
44 of 47 checks passed
@Sushisource
Sushisource deleted the docker-gen-protos-stderr branch July 21, 2026 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants