Skip to content

Remove google-genai compat shim, require 2.12+ #1709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DABH wants to merge 1 commit into from
Closed

Remove google-genai compat shim, require 2.12+ #1709

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ lambda-worker-otel = [
"opentelemetry-sdk-extension-aws>=2.0.0,<3",
]
aioboto3 = ["aioboto3>=10.4.0", "types-aioboto3[s3]>=10.4.0"]
google-genai = ["google-genai>=2.10.0,<3.0.0"]
google-genai = ["google-genai>=2.12.0,<3.0.0"]
strands-agents = ["strands-agents>=1.39.0"]

[project.urls]
Expand Down
24 changes: 0 additions & 24 deletions temporalio/contrib/google_genai/_compat.py
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion temporalio/contrib/google_genai/_gemini_activity.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,11 @@
from google.genai import Client as GeminiClient
from google.genai import errors as genai_errors
from google.genai import types
from google.genai._gaos.types.interactions.interaction import Interaction
from google.genai.types import HttpOptions
from google.genai.types import HttpResponse as SdkHttpResponse

from temporalio import activity
from temporalio.contrib.google_genai._compat import Interaction
from temporalio.contrib.google_genai._models import (
_GeminiApiRequest,
_GeminiApiResponse,
Expand Down
2 changes: 1 addition & 1 deletion temporalio/contrib/google_genai/_temporal_interactions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,10 @@
from typing import Any, cast

import pydantic
from google.genai._gaos.types.interactions.interaction import Interaction
from google.genai.interactions import InteractionSSEEvent

from temporalio import workflow as temporal_workflow
from temporalio.contrib.google_genai._compat import Interaction
from temporalio.contrib.google_genai._models import (
_GeminiInteractionIdRequest,
_GeminiInteractionRequest,
Expand Down
2 changes: 1 addition & 1 deletion tests/contrib/google_genai/test_gemini.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
import pytest
from google.genai import Client as GeminiClient
from google.genai import types
from google.genai._gaos.types.interactions.interaction import Interaction

@tconley1428 tconley1428 Jul 31, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're using internal imports to fix this?

from google.genai.interactions import (
Agent, # pyright: ignore[reportPrivateImportUsage]
InteractionSSEEvent,
Expand All @@ -44,7 +45,6 @@
GoogleGenAIPlugin,
activity_as_tool,
)
from temporalio.contrib.google_genai._compat import Interaction
from temporalio.contrib.google_genai._models import (
_GeminiApiRequest,
_GeminiApiResponse,
Expand Down
20 changes: 10 additions & 10 deletions uv.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading