Skip to content

fix: fall back to charge for legacy sessions - #86

Merged
brendanjryan merged 1 commit into
mainfrom
fix/session-charge-fallback
Aug 15, 2026
Merged

fix: fall back to charge for legacy sessions#86
brendanjryan merged 1 commit into
mainfrom
fix/session-charge-fallback

Conversation

@brendanjryan

@brendanjryan brendanjryan commented Aug 15, 2026

Copy link
Copy Markdown
Contributor

Motivation

Mixed payment challenges can route legacy session offers into the v2-only session path and prevent compatible charge payments. Fixes #82.

Summary

  • Gate session-first routing on sessionProtocol: v2
  • Fall back to generic payment selection for unversioned and v1 sessions
  • Add regression coverage and a patch changelog entry

Key design considerations

  • Reuse mppx protocol constants so routing matches the session method capability
  • Decide compatibility before session balance checks or stored-session mutations

@brendanjryan brendanjryan mentioned this pull request Aug 15, 2026
Closed
@brendanjryan
brendanjryan marked this pull request as ready for review August 15, 2026 04:14
@brendanjryan
brendanjryan merged commit ab8cb80 into main Aug 15, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

tempo request: session-first routing dead-ends on sessionProtocol-v1 session challenges instead of falling back to charge

1 participant

@brendanjryan