Skip to content

Fix RandomCentroidsInitialisation to safely handle cases where zero clusters are requested for a weight interval. #1289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Jun 2, 2026
+5 −1
Merged

Fix RandomCentroidsInitialisation to safely handle cases where zero clusters are requested for a weight interval. #1289

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion tensorflow_model_optimization/python/core/clustering/keras/clustering_centroids.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,6 @@ class LinearCentroidsInitialisation(AbstractCentroidsInitialisation):
def _calculate_centroids_for_interval(self, weight_interval,
number_of_clusters_for_interval):
if tf.math.less_equal(number_of_clusters_for_interval, 0):
# Return an empty array of centroids
return tf.constant([])

weight_min = tf.reduce_min(weight_interval)
Expand Down Expand Up @@ -247,6 +246,10 @@ class RandomCentroidsInitialisation(AbstractCentroidsInitialisation):

def _calculate_centroids_for_interval(self, weight_interval,
number_of_clusters_for_interval):
if tf.math.less_equal(number_of_clusters_for_interval, 0):
# Return an empty array of centroids
return tf.constant([])

weight_min = tf.reduce_min(weight_interval)
weight_max = tf.reduce_max(weight_interval)
cluster_centroids = tf.random.uniform(
Expand Down
1 change: 1 addition & 0 deletions tensorflow_model_optimization/python/core/clustering/keras/clustering_centroids_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,7 @@ def testDensityBasedClusterCentroidsWithSparsityPreservation(
@parameterized.parameters(
([0., 1., 2., 3., 4., 5., 6., 7., 8., 9., 10.], 5),
([0., 1., 2., 3., 3.1, 3.2, 3.3, 3.4, 3.5], 3),
([1.0, 2.0, 3.0], 3),
([-3., -2., -1., 0., 1.1, 2.2, 3.3, 4.4, 5.5, 6.6, 7.7, 8.8, 9.], 6))
def testRandomClusterCentroidsWithSparsityPreservation(
self, weights, number_of_clusters):
Expand Down
Loading