ci: align verify-global-install budget to script default (60s → 120s)#257
Open
theagenticguy wants to merge 1 commit into
Open
ci: align verify-global-install budget to script default (60s → 120s)#257theagenticguy wants to merge 1 commit into
theagenticguy wants to merge 1 commit into
Conversation
The macos-x64-node24-nvm leg has been flaking on `gate 4: install took 61s (> 60s budget)` — a 1-second margin miss on a clean install, not a real regression. scripts/verify-global-install.sh documents a 120s default and its own header explains the tight 60s "tripped on slow cells despite a clean install", but the workflow hardcoded MAX_INSTALL_SECS=60, contradicting that. The gate exists to catch an install that HANGS or refetches native prebuilts (ladybug + duckdb + onnxruntime), which on a loaded shared runner legitimately varies 30-90s — it is not a perf benchmark. Align the workflow to the script's 120s default. Fixes the recurring macOS-runner flake class tracked in #163. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Verify Global Installworkflow hardcodedMAX_INSTALL_SECS: "60", butscripts/verify-global-install.shdocuments a 120s default and its header explicitly notes the tight 60s "tripped on slow cells despite a clean install." This change deletes the override so the workflow uses the script's documented 120s ceiling.Why
The
macos-x64-node24-nvmleg flaked on the last release push (chore: release main #256,4c16f5b):A 1-second margin miss on a clean install — not a regression. The CI, CodeQL, Semgrep, Self-Scan, and Scorecard suites all passed on the same SHA; only this timing gate tripped.
The gate exists to catch an install that hangs or refetches the native prebuilts (ladybug + duckdb + onnxruntime — though note ADR 0019 has since removed ladybug/duckdb, leaving onnxruntime-node as the only native dep). On a loaded shared macOS runner a cold-cache global install legitimately varies 30–90s, so 60s was below the noise floor. 120s keeps the hang-detection intent while ending the margin flakes.
Blast radius
CI-only. One env value in one workflow step. No source or runtime change.
Fixes the recurring macOS-runner flake class tracked in #163.
🤖 Generated with Claude Code