acp_7_x: remove local xtensa config headers, use hal_xtensa#10985
Merged
lgirdwood merged 1 commit intoJul 10, 2026
Merged
Conversation
Remove the local copies of xtensa config headers for acp_7_x platform as they are now provided by hal_xtensa module via Zephyr (modules/hal/xtensa/zephyr/soc/amd_acp_7_3_adsp/xtensa/config/). The SOC_TOOLCHAIN_NAME 'amd_acp_7_3_adsp' maps to the hal_xtensa directory, making these local copies redundant. Also remove the zephyr_include_directories() workaround for include/arch path that was only needed to expose these local headers. Signed-off-by: sneha-voona <sneha.voona@amd.com>
sneha-voona
requested review from
abonislawski,
bhiregoudar,
dbaluta,
iuliana-prodan,
kv2019i,
lyakh and
sunilkumardommati
as code owners
Collaborator
|
Can one of the admins verify this patch?
|
lgirdwood
approved these changes
Jul 10, 2026
bhiregoudar
approved these changes
Jul 10, 2026
|
test this please |
Member
|
not tested by internal CI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the local copies of xtensa config headers for acp_7_x platform as they are now provided by hal_xtensa module via Zephyr (modules/hal/xtensa/zephyr/soc/amd_acp_7_3_adsp/xtensa/config/).
The SOC_TOOLCHAIN_NAME 'amd_acp_7_3_adsp' maps to the hal_xtensa directory, making these local copies redundant.
Also remove the zephyr_include_directories() workaround for include/arch path that was only needed to expose these local headers.